-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#534): Explicitly define default value for saveLocalCopy #535
Conversation
@anlesk any more tweaks to this coming or good to merge? |
@philosowaffle sorry, it is not ready yet. I was trying to fix both issues in a single hit, but because GH action runs on docker image that does not have zip installed - the latest addition of pre-zip is failing. |
I've used this action for zip on other workflows, should work here I believe. |
Interesting.. For some reason, it does not seem to be working as well (https://github.com/anlesk/peloton-to-garmin/actions/runs/6364291199/job/17280467282):
With output.zip being an empty archive file, even though |
@philosowaffle reverted zip operation back, as it will take more time to fix -- will file new PR. |
Really odd it doesn't seem to have the same directory context. I guess could always try running |
Yeah, that does the trick: |
When GH Action is triggered by cron - it does not respect input's default settings.
fixes #534